Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

On 07/29/15 at 11:38am, Robert Shearman wrote:

On 28/07/15 17:16, roopa wrote:

quoted

RTA_OIF is optional for ipv4 and ipv6 routes and we wanted to keep it
that way for mpls routes as well (Quagga is the application in our use
case).
It was a simple patch...until i realized the IPV6 dependency issues (I
will sure remember this next time).

Having read the code, I realise the nexthop isn't derived from the lookup.
Given that this can only work for the case where a path is recursive via a
connected nexthop, it seems to be of limited use.

I'm not familiar with the Quagga code, but is it worth adding this
additional complexity to the kernel rather than making a change to Quagga
instead, where presumably it already has code to derive the output interface
in the case of having a recursive route via a non-connected nexthop?

I think it's wrong to assume that it's always a single management
application that manages both parts of the route. At least for
underlays and overlays it is fairly common to run something like
Quagga to manage the underlay and use multiple other orchestration
tools on top to create virtual networks which should not be aware of
any underlay specifics.