Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route_output

On 7/28/15, 3:22 PM, Hannes Frederic Sowa wrote:

Hi roopa,

On Tue, Jul 28, 2015, at 21:28, roopa wrote:

quoted

   ipv6_stub_impl.ipv6_dst_lookup seems to require sk today.
But it only needs it to get 'net' in the beginning and sk is optional
afterwards.
I will submit a patch to add 'net' as an arg  to ipv6_dst_lookup.
Users of ipv6_dst_lookup are few and that seems like an easy change and
helps my patch.
If you or others think otherwise, pls let me know.

No need to extend this function at any cost. Simply add your own
function pointer to the struct if needed.

saw your this email after I hit send on the series. Since the new function pointer will be exactly similar to ipv6_dst_lookup
with just an additional argument, a new function pointer does not seem necessary. But i can certainly change it
to a new function pointer and resend if that is more acceptable.

Probably you have to move the ipv6_stub = &ipv6_stub_impl;
initialization in inet6_init down so you don't expose the function
pointer too early and thus it races with initialization (and error
handling seems to be incorrect in this function, too).

ok, will look.

thanks,
Roopa