Thread (15 messages) 15 messages, 6 authors, 2015-07-06

Re: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

From: Eric Dumazet <hidden>
Date: 2015-07-03 16:39:18

On Fri, 2015-07-03 at 16:18 +0000, David Laight wrote:
Even on x86 aligning the ethernet receive data on a 4n+2
boundary is likely to give marginally better performance
than aligning on a 4n boundary.
You are coming late to the party.

Intel guys decided to change NET_IP_ALIGN to 0 (it was 2 in the past)

commit ea812ca1b06113597adcd8e70c0f84a413d97544
Author: Alexander Duyck [off-list ref]
Date:   Tue Jun 29 18:38:00 2010 +0000

    x86: Align skb w/ start of cacheline on newer core 2/Xeon Arch
    
    x86 architectures can handle unaligned accesses in hardware, and it has
    been shown that unaligned DMA accesses can be expensive on Nehalem
    architectures.  As such we should overwrite NET_IP_ALIGN to resolve
    this issue.
    
    Cc: Thomas Gleixner [off-list ref]
    Cc: Ingo Molnar [off-list ref]
    Cc: "H. Peter Anvin" [off-list ref]
    Cc: x86@kernel.org
    Signed-off-by: Alexander Duyck [off-list ref]
    Signed-off-by: Jeff Kirsher [off-list ref]
    Acked-by: H. Peter Anvin [off-list ref]
    Signed-off-by: David S. Miller [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help