Thread (15 messages) 15 messages, 6 authors, 2015-07-06

RE: [PATCH net-next] net: macb: replace literal constant with NET_IP_ALIGN

From: David Laight <hidden>
Date: 2015-07-03 16:20:40

From: Eric Dumazet
Sent: 01 July 2015 23:14
To: Joe Perches
...
quoted
quoted
Then please use netdev_alloc_skb_ip_align(), so that you get rid of
skb_reserve()
It seems there are ~50 of these in the kernel tree
that could be converted.
Make sure the 2 is really NET_IP_ALIGN

Some hardwares need 2, even if NET_IP_ALIGN is 0 (on x86 arches for
example)
Even on x86 aligning the ethernet receive data on a 4n+2
boundary is likely to give marginally better performance
than aligning on a 4n boundary.

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help