Re: [PATCH 20/22] fjes: epstop_task
From: Sergei Shtylyov <hidden>
Date: 2015-06-18 13:55:39
Also in:
linux-acpi, platform-driver-x86
Hello. On 6/18/2015 3:49 AM, Taku Izumi wrote:
This patch adds epstop_task. This task is used to process other receiver's cancellation request.
Signed-off-by: Taku Izumi <redacted> --- drivers/platform/x86/fjes/fjes_hw.c | 34 ++++++++++++++++++++++++++++++++++ drivers/platform/x86/fjes/fjes_hw.h | 1 + drivers/platform/x86/fjes/fjes_main.c | 1 + 3 files changed, 36 insertions(+)
quoted hunk ↗ jump to hunk
diff --git a/drivers/platform/x86/fjes/fjes_hw.c b/drivers/platform/x86/fjes/fjes_hw.c index e07b266..c22679a 100644 --- a/drivers/platform/x86/fjes/fjes_hw.c +++ b/drivers/platform/x86/fjes/fjes_hw.c
[...]
quoted hunk ↗ jump to hunk
@@ -1123,3 +1126,34 @@ static void fjes_hw_update_zone_task(struct work_struct *work) } } +static void fjes_hw_epstop_task(struct work_struct *work) +{ + struct fjes_hw *hw = container_of(work, + struct fjes_hw, epstop_task);
Please start the continuation lines under 'work' on the first line.
+ struct fjes_adapter *adapter = (struct fjes_adapter *)hw->back;
+ int epid_bit;
+ unsigned long remain_bit;
+
+ while ((remain_bit = hw->epstop_req_bit)) {
+
Don't think this empty line is needed.
+ for (epid_bit = 0; remain_bit; (remain_bit >>= 1),
+ (epid_bit++)) {
Inner parens not needed, the comma operator has lowest priority.
+
+ if (remain_bit & 1) {
+
Don't think this empty line is needed.
[...]
WBR, Sergei