Re: [PATCH 01/22] fjes: Introduce FUJITSU Extended Socket Network Device driver
From: Joe Perches <joe@perches.com>
Date: 2015-06-18 01:47:40
Also in:
linux-acpi, platform-driver-x86
On Thu, 2015-06-18 at 09:49 +0900, Taku Izumi wrote:
This patch adds the basic code of FUJITSU Extended Socket Network Device driver.
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/platform/x86/fjes/fjes_main.c b/drivers/platform/x86/fjes/fjes_main.c
[]
+static acpi_status fjes_get_acpi_resource(struct acpi_resource *acpi_res,
+ void *data)
+{
+ struct resource *res = data;
+ struct acpi_resource_address32 *addr;
+ struct acpi_resource_irq *irq;
+
+ switch (acpi_res->type) {
+ case ACPI_RESOURCE_TYPE_ADDRESS32:
+ addr = &acpi_res->data.address32;
+ res[0].start = addr->address.minimum;
+ res[0].end = addr->address.minimum +
+ addr->address.address_length;Isn't this missing - 1? end = start + length - 1; ?
+static int __init fjes_init_module(void)
+{
+ int result;
+
+ pr_info("%s - version %s\n",
+ fjes_driver_string, fjes_driver_version);
+ pr_info("%s\n", fjes_copyright);Maybe emit copyright on the same line as version?