Thread (6 messages) flat view 6 messages, 3 authors, 2015-05-10

Re: [PATCH] net: mdio-gpio: Allow for unspecified bus id

From: Andrew Lunn <andrew@lunn.ch>
Date: 2015-05-08 16:51:37
Also in: lkml

quoted
quoted
-	snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id);
+	if (bus_id != -1)
+		snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id);
+	else
+		strncpy(new_bus->id, "gpio", MII_BUS_ID_SIZE);
Hi Bert

What happens if there are multiple platform_device's with -1?  You
should probably be using use idr_alloc().
It's an instance id per driver, not globally, and -1 specifically means it's
the only instance. From Documentation/driver-model/platform.txt:
Ah, did not know there can only be one with -1. I've used i2c where
this does not apply when registering adaptors. It will allocate a
unique id to each added with id = -1.

       Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help