Re: [PATCH] net: can: xilinx_can: fix extended frame handling

From
Marc Kleine-Budde <mkl@pengutronix.de>
Date
2015-05-01 08:20:53
Also in
linux-can, lkml
Reply to
Jeppe Ledet-Pedersen, 2015-04-29
On 04/29/2015 05:05 PM, Jeppe Ledet-Pedersen wrote:
Using IDR_SRR in RXFIFO_ID to test for the presence of data is only
valid for standard frames. For extended frames the bit is always 1 and
IDR_RTR should be used instead. This patch switches the check to use
CAN_RTR_FLAG which is correctly set when reading the ID.

The patch also changes the DW1/DW2 to be read unconditionally, since
this is necessary to remove the frame from the RXFIFO.

Signed-off-by: Jeppe Ledet-Pedersen <redacted>
Acked-by: Kedareswara rao Appana <redacted>
Applied to can. Added stable on Cc.

Thanks,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachments

Thread (2 messages) 2 messages, 2 authors, last reply 2015-05-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help