Re: [Xen-devel] [RFC PATCH 10/13] xen-netfront: refactor claim/release grant
From: Joao Martins <hidden>
Date: 2015-05-19 10:19:58
From: Joao Martins <hidden>
Date: 2015-05-19 10:19:58
On 18 May 2015, at 17:48, David Vrabel [off-list ref] wrote:
On 12/05/15 18:18, Joao Martins wrote:quoted
Refactors how grants are claimed/released/revoked by moving that code into claim_grant and release_grant helpers routines that can be shared in both TX/RX path.Reviewed-by: David Vrabel <redacted> But should this be generic? Is it useful to other frontends? And some of the line splitting looks a bit odd.
It looks like scsifront (lines 384-389, 418-423), blkfront (lines 250-257) and netfront both grant their buffers in the same way, so perhaps these two helpers could be reused.