On 18 May 2015, at 17:44, David Vrabel [off-list ref] wrote:

On 12/05/15 18:18, Joao Martins wrote:

quoted

Refactors a little bit how grants are stored by moving
grant_rx_ref/grant_tx_ref and grant_tx_page to its
own structure, namely struct grant.

Reviewed-by: David Vrabel <redacted>

Although...

quoted

--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c

@@ -87,6 +87,11 @@ struct netfront_cb {

/* IRQ name is queue name with "-tx" or "-rx" appended */
#define IRQ_NAME_SIZE (QUEUE_NAME_SIZE + 3)

+struct grant {
+	grant_ref_t ref;
+	struct page *page;
+};

Is this sort of structure (and the following patch) useful for other
frontends?

Perhaps not. It seems that blkfront is the only one that uses similar structure.
Though it creates a struct grant containing an additional struct list_node
field that is used for the free grants list within blkfront. In my case I
extend the struct grant later on the patch  "xen-netfront: implement RX 
persistent grants" to have the struct ubuf_info.