Re: [PATCH net-next V3 02/11] net/mlx5_core: Add EQ renaming mechanism
From: David Miller <davem@davemloft.net>
Date: 2015-05-11 17:40:10
From: David Miller <davem@davemloft.net>
Date: 2015-05-11 17:40:10
From: Amir Vadai <redacted> Date: Sun, 10 May 2015 12:38:57 +0300
+int mlx5_rename_eq(struct mlx5_core_dev *dev, int eq_ix, char *name)
+{
+ struct mlx5_priv *priv = &dev->priv;
+ struct mlx5_eq_table *table = &priv->eq_table;
+ struct mlx5_eq *eq;
+ int err = -ENOENT;
+
+ spin_lock(&table->lock);
+ list_for_each_entry(eq, &table->comp_eqs_list, list) {
+ if (eq->index == eq_ix) {
+ snprintf(priv->irq_info[eq_ix].name, MLX5_MAX_IRQ_NAME,
+ "%s-%d", name, eq_ix);
+ err = 0;
+ break;
+ }
+ }
+ spin_unlock(&table->lock);
+
+ return err;
+}You have to be very careful with this. If you change these names after the request_irq() call(s), the new name string will not propagate to /proc/interrupts output etc. Looking at your later patches, this seems to be invoked very late in mlx5e_open_locked(), so I am concerned.