Re: [PATCH net-next V3 08/11] net/mlx5_core: Set/Query port MTU commands
From: Sergei Shtylyov <hidden>
Date: 2015-05-10 16:32:15
Hello. On 5/10/2015 12:39 PM, Amir Vadai wrote:
From: Saeed Mahameed <redacted>
Introduce set/Query low level functions to access MTU in hardware. To be used by the netdev.
Signed-off-by: Saeed Mahameed <redacted> Signed-off-by: Amir Vadai <redacted> --- drivers/net/ethernet/mellanox/mlx5/core/port.c | 56 ++++++++++++++++++++++++++ include/linux/mlx5/driver.h | 4 ++ 2 files changed, 60 insertions(+)
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/port.c b/drivers/net/ethernet/mellanox/mlx5/core/port.c index 742a6fb..e56a0b6 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/port.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/port.c@@ -211,3 +211,59 @@ int mlx5_query_port_status(struct mlx5_core_dev *dev, u8 *status)
[...]
+int mlx5_set_port_mtu(struct mlx5_core_dev *dev, int mtu)
+{
+ u32 in[MLX5_ST_SZ_DW(pmtu_reg)];
+ u32 out[MLX5_ST_SZ_DW(pmtu_reg)];
+ int err;
+
+ memset(in, 0, sizeof(in));
+
+ MLX5_SET(pmtu_reg, in, admin_mtu, mtu);
+ MLX5_SET(pmtu_reg, in, local_port, 1);
+
+ err = mlx5_core_access_reg(dev, in, sizeof(in), out,
+ sizeof(out), MLX5_REG_PMTU, 0, 1);
+
+ return err;
Why not just return directly?
[...]
WBR, Sergei