Thread (44 messages) 44 messages, 6 authors, 2015-05-09

Re: [PATCH net-next v5 12/21] switchdev: remove old switchdev_port_bridge_setlink

From: Scott Feldman <hidden>
Date: 2015-05-08 05:07:07

On Thu, May 7, 2015 at 8:36 AM, Jiri Pirko [off-list ref] wrote:
Tue, May 05, 2015 at 07:34:48PM CEST, sfeldma@gmail.com wrote:
quoted
From: Scott Feldman <redacted>

New attr-based bridge_setlink can recurse lower devs and recover on err, so
remove old wrapper.  Also, restore br_setlink back to original and don't
call into SELF port driver.  rtnetlink.c:bridge_setlink already does a call
into port driver for SELF.

Signed-off-by: Scott Feldman <redacted>
---
include/net/switchdev.h   |   17 -----------------
net/bridge/br_netlink.c   |   11 +----------
net/switchdev/switchdev.c |   30 ------------------------------
3 files changed, 1 insertion(+), 57 deletions(-)
diff --git a/include/net/switchdev.h b/include/net/switchdev.h
index aa6c370..ce5ceb2 100644
--- a/include/net/switchdev.h
+++ b/include/net/switchdev.h
@@ -122,8 +122,6 @@ int switchdev_port_attr_set(struct net_device *dev,
                          struct switchdev_attr *attr);
int switchdev_port_obj_add(struct net_device *dev, struct switchdev_obj *obj);
int switchdev_port_obj_del(struct net_device *dev, struct switchdev_obj *obj);
-int switchdev_port_bridge_setlink(struct net_device *dev, struct nlmsghdr *nlh,
-                            u16 flags);
I don't understand why you remove this. Would for example bond compile
after this?
Looks like a patching error on my part...fixed in v6...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help