Re: [PATCH net-next v5 12/21] switchdev: remove old switchdev_port_bridge_setlink
From: Jiri Pirko <jiri@resnulli.us>
Date: 2015-05-07 15:33:44
From: Jiri Pirko <jiri@resnulli.us>
Date: 2015-05-07 15:33:44
Tue, May 05, 2015 at 07:34:48PM CEST, sfeldma@gmail.com wrote:
From: Scott Feldman <redacted> New attr-based bridge_setlink can recurse lower devs and recover on err, so remove old wrapper. Also, restore br_setlink back to original and don't call into SELF port driver. rtnetlink.c:bridge_setlink already does a call into port driver for SELF.
Although the patch description does not say so, this patch really removes "ndo_dflt_switchdev_port_bridge_setlink". ....
}
- if (p && !(flags & BRIDGE_FLAGS_SELF)) {
- /* set bridge attributes in hardware if supported
- */
- ret_offload = switchdev_port_bridge_setlink(dev, nlh, flags);
- if (ret_offload && ret_offload != -EOPNOTSUPP)
- br_warn(p->br, "error setting attrs on port %u(%s)\n",
- (unsigned int)p->port_no, p->dev->name);
- }
-Also, I think that this hunk should be as a separate patch as I really don't see direct relation with the rest of the patch.