Re: [RFC PATCH net-next 0/8] Convert some skb_<foo> functions to void
From: Joe Perches <joe@perches.com>
Date: 2015-05-06 16:14:50
On Wed, 2015-05-06 at 05:19 -0700, Eric Dumazet wrote:
On Tue, 2015-05-05 at 16:38 -0700, Joe Perches wrote:quoted
Another thing that's fairly common is an skb_put followed by a memcpy or memset. Adding a couple of functions for those like: void *skb_put_memcpy(struct sk_buff *skb, void *from, size_t size); void *skb_put_memset(struct sk_buff *skb, int c, size_t size); would reduce code size and improve performance a little.
[]
We understand the code as is, with regular memcpy() and memset() These functions are fine. They were fine 20 years ago, nothing changed.
Prefer speed and size improvements over stasis. alloc+memset works, zalloc exists. Using these functions would reduce a non-modular defconfig x86-64 net/built-in.o by a couple kb. Probably double that for a kernel. These functions would be used in the packet processing path for wireless too.