Thread (14 messages) flat view 14 messages, 3 authors, 2015-05-06

Re: [RFC PATCH net-next 0/8] Convert some skb_<foo> functions to void

From: David Miller <davem@davemloft.net>
Date: 2015-05-05 23:20:05

From: Joe Perches <joe@perches.com>
Date: Mon, 04 May 2015 13:32:30 -0700
On Mon, 2015-05-04 at 13:05 -0700, Joe Perches wrote:
quoted
unsigned char * return values are sometimes awkward to work with.
Changing the return to void * is sometimes clearer.

The only uses of the return type is to do sets like
    *skb_puts(skb, 1) = char;
    
Adding another function specifically for that purpose allows the return
type to become void.
Obviously, this shouldn't be applied as-is.

It spans too many subsystems and can be done
more incrementally.

Also, there are some missing conversions so
this won't compile properly (sorry 'bout that)
I have no fundamental issues with this series once you fix up those
issues.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help