On Tue, Apr 14, 2015 at 05:35:34PM +0100, Al Viro wrote:
On Tue, Apr 14, 2015 at 04:25:24PM +0000, David Laight wrote:
quoted
From: Al Viro
quoted
Sent: 11 April 2015 22:18
it's equal to iov_iter_count(&msg->msg_iter) in all cases
I don't know whether this is guaranteed for iov[] that come from
userspace.
In any case iov_iter_count() is non-trivial and you don't
really want to call it when unnecessary.
Really?
static inline size_t iov_iter_count(struct iov_iter *i)
{
return i->count;
}
Incidentally, have you even looked at the patch? sock_write_iter():
- res = sock_sendmsg(sock, &msg, iov_iter_count(from));
+ res = sock_sendmsg(sock, &msg);
sys_sendto():
- err = sock_sendmsg(sock, &msg, iov_iter_count(&msg.msg_iter));
+ err = sock_sendmsg(sock, &msg);
__sys_sendmsg():
- total_len = iov_iter_count(&msg_sys->msg_iter);
- err = sock_sendmsg(sock, msg_sys, total_len);
+ err = sock_sendmsg(sock, msg_sys);
kernel_sendmsg():
iov_iter_kvec(&msg->msg_iter, WRITE | ITER_KVEC, vec, num, size);
- return sock_sendmsg(sock, msg, size);
+ return sock_sendmsg(sock, msg);
... and iov_iter_kvec() sets ->count to its last argument, so after the
first line we'll have iov_iter_count(&msg->msg_iter) == size.
svc_sendto():
- if (sock_sendmsg(sock, &msg, 0) < 0)
+ if (sock_sendmsg(sock, &msg) < 0)
and msg->msg_iter is all-zeroes there, including ->msg_iter.count.
In cases when iov comes from userland we used to have iov_iter_count(...)
passed there; no need to even look its definition up. It's an equivalent
transformation, no matter what...