Hello.

On 03/30/2015 06:49 PM, Oliver Hartkopp wrote:

quoted

quoted

+    /* eliminate multiple filter matches for the same skb */
+    if (*this_cpu_ptr(ro->uniq_skb) == oskb &&
+        ktime_equal(*this_cpu_ptr(ro->uniq_tstamp), oskb->tstamp)) {
+            return;

quoted

    Over-indented.

I was asked about that before. AFAIK the *skb is no unique identifier over a
longer period of time. But together with the timestamp it becomes unique.
Or do you have a better solution to detect identical skbs?

    I just said that *return* was too far to the right, that's all. :-)

CAN skbs do not have a (rx)hash so far and I wonder if it's worth to compute
the hash in favor to check the *skb and the timestamp here ...

[...]

Best regards,
Oliver

WBR, Sergei