Thread (17 messages) 17 messages, 3 authors, 2015-03-31

Re: [PATCH RFC v2 1/2] can: fix multiple delivery of a single CAN frame for overlapping CAN filters

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2015-03-30 10:36:56
Also in: linux-can

On 03/30/2015 12:29 PM, Oliver Hartkopp wrote:
On 30.03.2015 11:50, Marc Kleine-Budde wrote:
quoted
quoted
  	can_err_mask_t err_mask;
+	struct sk_buff __percpu **uniq_skb;
+	ktime_t __percpu *uniq_tstamp;
What about creating a struct to hold the ktime_t and the skb? BTW: the
pointer to the skb can be marked as const.
Don't think so.

The pointer points to some allocated memory.
Yes, but the allocated memory points to a skb which is not modified, so
it's a:

struct sk_buff __percpu * const *uniq_skb;

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help