Re: [PATCH] bgmac: ratelimit warning messages
From: Rafał Miłecki <zajec5@gmail.com>
Date: 2015-03-06 23:27:49
Also in:
lkml
On 6 March 2015 at 19:17, Peter Senna Tschudin [off-list ref] wrote:
quoted hunk ↗ jump to hunk
On my test environment the troughput of a file transfer drops from 4.4Mbps to 116Kbps due the number of repeated warning messages. Adding printk_ratelimit() solves the issue without removing the warning message. Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> --- drivers/net/ethernet/broadcom/bgmac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c index 676ffe0..d1a259b 100644 --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c@@ -302,7 +302,7 @@ static int bgmac_dma_rx_skb_for_slot(struct bgmac *bgmac, slot->skb = skb; slot->dma_addr = dma_addr; - if (slot->dma_addr & 0xC0000000) + if ((slot->dma_addr & 0xC0000000) && printk_ratelimit()) bgmac_warn(bgmac, "DMA address using 0xC0000000 bit(s), it may need translation trick\n"); return 0;
Nack. Please just drop this code.
From what I understand network works for you. I've also checked
Broadcom's open source code, and on SoC we can always safely write whole low 32b.