Re: [v2 PATCH 3/10] rhashtable: Allow hashfn to be unset
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2015-03-23 10:18:54
On Mon, Mar 23, 2015 at 09:58:42AM +0000, Thomas Graf wrote:
nft_hash sets key_len to set->klen and passes it to rhashtable_init(). rhashtable_init() should then fall back to jhash() or jhash2() if no hashfn is provided. Why is the logic in rht_key_hashfn() different? Actually, in which case is ht->p.hashfn not set in rht_key_hashfn()?
jhash can be used in place of jhash2, the only difference is that jhash is less optimised and uses unaligned loads. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt