Re: [PATCH net-next v2 0/3] switchdev: support stp updates on stacked netdevices

From: Jiri Pirko <jiri@resnulli.us>
Date: Sun, 15 Mar 2015 17:56:32 +0100

Fri, Mar 13, 2015 at 05:31:56PM CET, davem@davemloft.net wrote:

quoted

From: roopa <redacted>
Date: Fri, 13 Mar 2015 06:25:24 -0700

quoted

David, if you mean not touch bond and team but have the switchdev
api do it transparently, yes, i had it that way initially.  And i do
liked it that way as well. But the feedback i received (during the
initial introduction of this for setlink/dellink) was to make it
explicit for each master.

I think the concern is that we only want to do this for devices
for which it is safe to "traverse" down like this.

Yes, that was my point. Also, some layered drivers might want to do some
individual magic, propagate on condition, etc. I think it is clearer
architecture. And also, you can see right away what is happening. By
doing the travelsal directly in switchdev code, that is in the shadow :/

I think special behavior would be the exception rather than the norm,
and we should code our interfaces for the common case.

This means we can add a per-device flag to avoid this logic if
necessary.

Notice how you use lots of words like "might", and I hate designing
interfaces without hard explicit real word examples of the actual
precise need.

So don't use open ended reasons like that for justifying the design of
our interfaces.