Re: [PATCH net-next v2 0/3] switchdev: support stp updates on stacked netdevices

On 3/13/15, 9:31 AM, David Miller wrote:

From: roopa <redacted>
Date: Fri, 13 Mar 2015 06:25:24 -0700

quoted

David, if you mean not touch bond and team but have the switchdev
api do it transparently, yes, i had it that way initially.  And i do
liked it that way as well. But the feedback i received (during the
initial introduction of this for setlink/dellink) was to make it
explicit for each master.

I think the concern is that we only want to do this for devices
for which it is safe to "traverse" down like this.

But frankly I cannot think of any layered device where we would
not want to do this.

Let's go back to the simple scheme where we unconditionally traverse
and if we hit a problem case we'll figure out how to deal with it
then, ok?

ok, sounds great. I will respin. Thanks!.

I wanted to move all three ops setlink/dellink/stpupdate initially, but 
now realize that
for something like the below to work, you will need the setlink/dellink 
support in the
bond and team driver because the call goes into the 'dev' driver 
directly without
calling into the switchdev api.

bridge link set dev bond0 learning off self

This case can be fixed too, however, it needs some more work in 
rtnetlink.c handling of 'self'.
The stp update api does not have this problem. I will respin the current 
stp update series first.