From: David Miller [mailto:davem@davemloft.net]
Sent: Thursday, February 19, 2015 11:36 AM
To: Vatsavayi, Raghu
Cc: netdev@vger.kernel.org; Chickles, Derek; Burla, Satananda; Manlunas,
Felix; Vatsavayi, Raghu
Subject: Re: [PATCH net-next v5] Add support of Cavium Liquidio ethernet
adapters

From: Raghu Vatsavayi <redacted>
Date: Wed, 11 Feb 2015 17:20:42 -0800

quoted

+	pci_unmap_single(lio->oct_dev->pci_dev, finfo->dptr, skb->len,
+			 PCI_DMA_TODEVICE);

Please use the dma_*() variants of the DMA interfaces for which you
will pass in a reference to the struct device embedded in the pci_dev.

This will allow you to later make use of various generic facilities
we will build for DMA mapping SKBs in the networking, allocating
networknig page frags, etc.

You said you *will* be building these facilities. Are there any now
that we can take advantage of? (We'll move to the dma_* variants
regardless.)

Also, do you have any remaining style / global comments that we should
address?

Thanks,
Derek