Thread (52 messages) 52 messages, 9 authors, 2015-06-11

RE: [PATCH net-next v4] Add support of Cavium Liquidio ethernet adapters

From: Chickles, Derek <hidden>
Date: 2015-02-06 22:00:37

From: David Miller [mailto:davem@davemloft.net]
Sent: Monday, February 02, 2015 7:01 PM
quoted
 create mode 100644
drivers/net/ethernet/cavium/liquidio/cn66xx_device.c
 ...
quoted
 create mode 100644
drivers/net/ethernet/cavium/liquidio/cn68xx_device.c

These two file have several functions which are nearly identical.

Especially the device init register programming sequence.

Please consolidate the common code some more.

THanks.
Hi,

We've now consolidated 66xx and 68xx device init and access functions as
well as ethtool-related redundant stuff. This will come in a new patch
coming shortly.

Is there anything else you'd like to see us address?

Thanks,
Derek
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help