Re: [PATCH] net, ethernet, LLVMLinux: Add missing MODULE_DEVICE_TABLE()

On 01/29/15 01:10, Arnd Bergmann wrote:

On Wednesday 28 January 2015 22:42:28 David Miller wrote:

quoted

From: Behan Webster <redacted>
Date: Wed, 28 Jan 2015 17:36:14 -0800

quoted

Missing MODULE_DEVICE_TABLE for pci ids from benet driver found by clang.

Signed-off-by: Behan Webster <redacted>
Suggested-by: Arnd Bergmann <arnd@arndb.de>

Why are you removing the device table?

Behan took a patch that I did earlier and split it up to add descriptions.
The patch is correct, but he either misunderstood or misexpressed the
intention.

I was tired and rushed this submission in my preparation for FOSDEM.
Apologies to all.

I neglected to write the commit log when I first split the patch, and
didn't look hard enough this time.

This driver has two identical lines that both say 

MODULE_DEVICE_TABLE(pci, be_dev_ids);

This is indeed the case.

I don't remember the exact symptom, but llvm/clang trips over this, while gcc
silently ignores the second one.

It claims that it is defined more than once.

Behan

-- 
Behan Webster
behanw@converseincode.com