Thread (5 messages) flat view 5 messages, 3 authors, 2015-01-29

Re: [PATCH] net, ethernet, LLVMLinux: Add missing MODULE_DEVICE_TABLE()

From: Arnd Bergmann <arnd@arndb.de>
Date: 2015-01-29 09:11:34
Also in: lkml

On Wednesday 28 January 2015 22:42:28 David Miller wrote:
From: Behan Webster <redacted>
Date: Wed, 28 Jan 2015 17:36:14 -0800
quoted
Missing MODULE_DEVICE_TABLE for pci ids from benet driver found by clang.

Signed-off-by: Behan Webster <redacted>
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Why are you removing the device table?
Behan took a patch that I did earlier and split it up to add descriptions.
The patch is correct, but he either misunderstood or misexpressed the
intention.

This driver has two identical lines that both say 

MODULE_DEVICE_TABLE(pci, be_dev_ids);

I don't remember the exact symptom, but llvm/clang trips over this, while gcc
silently ignores the second one.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help