Re: [PATCH 2/2] Fix copy-paste bug: assign from src struct not dest
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2015-01-05 09:54:43
Also in:
linux-wireless, lkml
On Sun, 2015-01-04 at 19:00 +0100, Giel van Schijndel wrote:
quoted hunk
--- drivers/net/wireless/ti/wlcore/acx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/wireless/ti/wlcore/acx.c b/drivers/net/wireless/ti/wlcore/acx.c index beb354c..93a2fa8 100644 --- a/drivers/net/wireless/ti/wlcore/acx.c +++ b/drivers/net/wireless/ti/wlcore/acx.c@@ -1725,7 +1725,7 @@ int wl12xx_acx_config_hangover(struct wl1271 *wl) acx->decrease_delta = conf->decrease_delta; acx->quiet_time = conf->quiet_time; acx->increase_time = conf->increase_time; - acx->window_size = acx->window_size; + acx->window_size = conf->window_size;
It would be far better to fix the bug *first*, that way the bugfix can be cherry-picked/applied to trees that don't have the alignment. (And anyway I question the value of the alignment - if you really want to make this bug disappear you could perhaps use a macro) johannes