Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

From
Ben Hutchings <hidden>
Date
2015-01-28 17:24:51
Also in
virtualization
Reply to
Michael S. Tsirkin, 2015-01-28
On Wed, 2015-01-28 at 11:46 +0200, Michael S. Tsirkin wrote:
On Wed, Jan 28, 2015 at 09:25:08AM +0100, Hannes Frederic Sowa wrote:
[...]
quoted
I see fragmentation id generation still as security critical:
When Eric patched the frag id generator in 04ca6973f7c1a0d ("ip: make IP
identifiers less predictable") I could patch my kernels and use the
patch regardless of the machine being virtualized or not. It was not
dependent on the hypervisor.
And now it's even easier - just patch the hypervisor, and all VMs
automatically benefit.
[...]

You are advocating that the hypervisor should continue to act as a
middle-box that quietly modifies packets.  This may be useful to protect
guests that have poor fragment ID generation, but then that should be an
optional netfilter module and *not* the default.  The default should be
that UFO has no effect on the packet headers on the wire, and therefore
that the fragment ID is chosen by the IPv6 stack in the guest.

Ben.

-- 
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.
Thread (31 messages) 31 messages, 7 authors, last reply 2015-01-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help