Thread (31 messages) 31 messages, 7 authors, 2015-01-28

Re: [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set.

From: David Miller <davem@davemloft.net>
Date: 2015-01-27 08:27:34

From: Ben Hutchings <redacted>
Date: Tue, 27 Jan 2015 02:47:54 +0000
On Mon, 2015-01-26 at 09:37 -0500, Vladislav Yasevich wrote:
quoted
If the IPv6 fragment id has not been set and we perform
fragmentation due to UFO, select a new fragment id.
When we store the fragment id into skb_shinfo, set the bit
in the skb so we can re-use the selected id.
This preserves the behavior of UFO packets generated on the
host and solves the issue of id generation for packet sockets
and tap/macvtap devices.

This patch moves ipv6_select_ident() back in to the header file.  
It also provides the helper function that sets skb_shinfo() frag
id and sets the bit.

It also makes sure that we select the fragment id when doing
just gso validation, since it's possible for the packet to
come from an untrusted source (VM) and be forwarded through
a UFO enabled device which will expect the fragment id.

CC: Eric Dumazet <edumazet@google.com>
Signed-off-by: Vladislav Yasevich <redacted>
Applied, thanks Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help