Re: [PATCH 1/2] rhashtable: Introduce rhashtable_walk_*
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2015-01-27 20:39:51
Also in:
netfilter-devel
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2015-01-27 20:39:51
Also in:
netfilter-devel
On Tue, Jan 27, 2015 at 11:40:28AM +0000, Thomas Graf wrote:
This is unrelated to resize run control though, the reason is that I'm converting tcp_hashinfo et al and they require a hybrid approach. The tables may be too big to construct a parallel data structure, we don't want to hold off inserts or deletes while the expensive dump is underway. Even though we can't build a shadow structure while locking everybody else out, we still want to provide a way to somehow achieve consistent information. I think that NLM_F_INTR with fallback to restarting the dump is a good option and very easy to implement. In that case, we want to lock out resize from dumping iterations but still allow parallel insert/delete.
Well I guess Dave needs to make the call. Do we want to allow lockless walks over the hash table or not? Personally I don't think a linked list is that big a deal. But then you guys were agonsing over a single pointer so who knows. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt