Re: [PATCH 1/2] rhashtable: Introduce rhashtable_walk_*
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2015-01-27 09:55:32
Also in:
netfilter-devel
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2015-01-27 09:55:32
Also in:
netfilter-devel
On Tue, Jan 27, 2015 at 09:45:41AM +0000, Thomas Graf wrote:
OK. I'll wait for your netfilter approach before posting NLM_F_INTR patches.
Why would we still need the INTR stuff given that Dave has asked for this to be done outside of rhashtable? What I'm planning on doing right now is to divide rhashtable users into two camps, lockless insert/removal vs. locked insert/removal. netfilter will obviously fall into the latter camp. For those with locked insert/removal I will make resizing/rehashing synchronous since there is zero benefit from doing it in a separate thread. Once that is done you can then easily walk the table by just holding the lock, which is what netfilter does today. I'll probably make netlink locked too since it's much simpler that way. Only really high performance users like TCP/UDP sockets need lockless insert/removal and the complexity that comes with it. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt