Re: [PATCH 1/2] rhashtable: Introduce rhashtable_walk_*

From
Patrick McHardy <hidden>
Date
2015-01-27 13:09:57
Also in
netfilter-devel
Reply to
Herbert Xu, 2015-01-27
On 27.01, Herbert Xu wrote:
On Tue, Jan 27, 2015 at 11:16:04AM +0000, Thomas Graf wrote:
quoted
No objection. I have a patch prepared which allows the user to
provide ht->mutex himself so nfset can provide its own existing
mutex to rhashtable and lock out the resizes from inserts,
removals and dump iterations automatically That would restore the
old behaviour of the nfset API without major surgery.
If you take the mutex you might as well just make it synchronous.
There is zero difference.

Maybe you misunderstood my email.  I'm not making it synchronous
for everybody, just those that always take a lock on inserts/removals
and therefore don't need per-bucket locks.
Actually I have a patchset queued that adds runtime additions and
removals, both active and timeout based. So netfilter won't have
pure synchronous behaviour anymore.
Thread (79 messages) 79 messages, 6 authors, last reply 2015-02-03
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help