Re: [PATCH net] openvswitch: packet messages need their own probe attribtue
From: Pravin Shelar <hidden>
Date: 2015-01-14 21:22:31
On Wed, Jan 14, 2015 at 5:56 AM, Thomas Graf [off-list ref] wrote:
User space is currently sending a OVS_FLOW_ATTR_PROBE for both flow
and packet messages. This leads to an out-of-bounds access in
ovs_packet_cmd_execute() because OVS_FLOW_ATTR_PROBE >
OVS_PACKET_ATTR_MAX.
Introduce a new OVS_PACKET_ATTR_PROBE with the same numeric value
as OVS_FLOW_ATTR_PROBE to grow the range of accepted packet attributes
while maintaining to be binary compatible with existing OVS binaries.
Fixes: 05da589 ("openvswitch: Add support for OVS_FLOW_ATTR_PROBE.")
Reported-by: Sander Eikelenboom <redacted>
Tracked-down-by: Florian Westphal [off-list ref]
Signed-off-by: Thomas Graf <tgraf@suug.ch>
---Looks good. Acked-by: Pravin B Shelar <redacted>