Copying ovs-dev mailing list and thus qutoing full message.
On 01/14/15 at 01:14pm, Sander Eikelenboom wrote:
quoted
Hi,
I was testing 3.19-rc4 with openvswitch and encountered the splat below.
What version of OVS are you using? Did this work properly with rc3 or
an older kernel?
seems like it was introduced via 05da5898a96c
(openvswitch: Add support for OVS_FLOW_ATTR_PROBE).
It adds test for OVS_FLOW_ATTR_PROBE to ovs_packet_cmd_execute() but
this function seems to only expect OVS_PACKET_ATTR_* (so we get
out-of-bounds access)?
Wednesday, January 14, 2015, 2:00:05 PM, you wrote:
Copying ovs-dev mailing list and thus qutoing full message.
On 01/14/15 at 01:14pm, Sander Eikelenboom wrote:
quoted
Hi,
I was testing 3.19-rc4 with openvswitch and encountered the splat below.
What version of OVS are you using? Did this work properly with rc3 or
an older kernel?
Hi Thomas,
Don't know for sure, i haven't seen it before, but on the other hand after a
reboot it is running fine now for some time.
So it seems it's not reliably reproducible :(.
OVS version is current Debian wheezy:
ii openvswitch-common 1.4.2+git20120612-9.1~deb7u1 amd64 Open vSwitch common components
ii openvswitch-controller 1.4.2+git20120612-9.1~deb7u1 amd64 Open vSwitch controller implementation
ii openvswitch-pki 1.4.2+git20120612-9.1~deb7u1 all Open vSwitch public key infrastructure dependency package
ii openvswitch-switch 1.4.2+git20120612-9.1~deb7u1 amd64 Open vSwitch switch implementations
--
Sander
From: Thomas Graf <tgraf@suug.ch> Date: 2015-01-14 13:13:15
On 01/14/15 at 02:03pm, Florian Westphal wrote:
Thomas Graf [off-list ref] wrote:
quoted
Copying ovs-dev mailing list and thus qutoing full message.
On 01/14/15 at 01:14pm, Sander Eikelenboom wrote:
quoted
Hi,
I was testing 3.19-rc4 with openvswitch and encountered the splat below.
What version of OVS are you using? Did this work properly with rc3 or
an older kernel?
seems like it was introduced via 05da5898a96c
(openvswitch: Add support for OVS_FLOW_ATTR_PROBE).
It adds test for OVS_FLOW_ATTR_PROBE to ovs_packet_cmd_execute() but
this function seems to only expect OVS_PACKET_ATTR_* (so we get
out-of-bounds access)?
Absolutely, just came to the same conclusion independently. I'll send
a fix.
From: Thomas Graf <tgraf@suug.ch> Date: 2015-01-14 13:56:21
User space is currently sending a OVS_FLOW_ATTR_PROBE for both flow
and packet messages. This leads to an out-of-bounds access in
ovs_packet_cmd_execute() because OVS_FLOW_ATTR_PROBE >
OVS_PACKET_ATTR_MAX.
Introduce a new OVS_PACKET_ATTR_PROBE with the same numeric value
as OVS_FLOW_ATTR_PROBE to grow the range of accepted packet attributes
while maintaining to be binary compatible with existing OVS binaries.
Fixes: 05da589 ("openvswitch: Add support for OVS_FLOW_ATTR_PROBE.")
Reported-by: Sander Eikelenboom <redacted>
Tracked-down-by: Florian Westphal [off-list ref]
Signed-off-by: Thomas Graf <tgraf@suug.ch>
---
include/uapi/linux/openvswitch.h | 4 ++++
net/openvswitch/datapath.c | 3 ++-
2 files changed, 6 insertions(+), 1 deletion(-)
On Wed, Jan 14, 2015 at 5:56 AM, Thomas Graf [off-list ref] wrote:
User space is currently sending a OVS_FLOW_ATTR_PROBE for both flow
and packet messages. This leads to an out-of-bounds access in
ovs_packet_cmd_execute() because OVS_FLOW_ATTR_PROBE >
OVS_PACKET_ATTR_MAX.
Introduce a new OVS_PACKET_ATTR_PROBE with the same numeric value
as OVS_FLOW_ATTR_PROBE to grow the range of accepted packet attributes
while maintaining to be binary compatible with existing OVS binaries.
Fixes: 05da589 ("openvswitch: Add support for OVS_FLOW_ATTR_PROBE.")
Reported-by: Sander Eikelenboom <redacted>
Tracked-down-by: Florian Westphal [off-list ref]
Signed-off-by: Thomas Graf <tgraf@suug.ch>
This is kind of a nasty bug, thanks for fixing it.
Reviewed-by: Jesse Gross <redacted>
On Wed, Jan 14, 2015 at 5:56 AM, Thomas Graf [off-list ref] wrote:
User space is currently sending a OVS_FLOW_ATTR_PROBE for both flow
and packet messages. This leads to an out-of-bounds access in
ovs_packet_cmd_execute() because OVS_FLOW_ATTR_PROBE >
OVS_PACKET_ATTR_MAX.
Introduce a new OVS_PACKET_ATTR_PROBE with the same numeric value
as OVS_FLOW_ATTR_PROBE to grow the range of accepted packet attributes
while maintaining to be binary compatible with existing OVS binaries.
Fixes: 05da589 ("openvswitch: Add support for OVS_FLOW_ATTR_PROBE.")
Reported-by: Sander Eikelenboom <redacted>
Tracked-down-by: Florian Westphal [off-list ref]
Signed-off-by: Thomas Graf <tgraf@suug.ch>
---