Thread (9 messages) 9 messages, 2 authors, 2014-12-29

Re: [RFC PATCH 2/6] cdc_ncm: be more precise in comments for cdc_ncm_prepare_skb_ncm16

From: Enrico Mioso <hidden>
Date: 2014-12-29 13:37:29

Thank you Sergei: for your time and review. I'll be careful to this.
Wish you best regards too - and good new year!

Enrico



On Mon, 29 Dec 2014, Sergei Shtylyov wrote:
Date: Mon, 29 Dec 2014 14:29:40
From: Sergei Shtylyov <redacted>
To: Enrico Mioso <redacted>, netdev@vger.kernel.org
Subject: Re: [RFC PATCH 2/6] cdc_ncm: be more precise in comments for
    cdc_ncm_prepare_skb_ncm16

Hello.

On 12/29/2014 1:09 PM, Enrico Mioso wrote:
quoted
The function might return NULL: callers must be prepared to this 
possibility.
quoted
Signed-Off-By: Enrico Mioso <redacted>
---
  drivers/net/usb/cdc_ncm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
quoted
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 48fee7a..bcd9437 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -1015,7 +1015,7 @@ static struct usb_cdc_ncm_ndp16 *cdc_ncm_ndp16(struct 
cdc_ncm_ctx *ctx, struct s
  }

  /* Allocate new SKB for use with 16-bit NCM according to actual TX/RX
-	settings */
+	settings; returns NULL in case of errors */
  BTW, the preferred style for the multi-line comments in the networking 
code is:

/* bla
* bla
*/

WBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help