Re: [RFC PATCH 2/6] cdc_ncm: be more precise in comments for cdc_ncm_prepare_skb_ncm16
From: Sergei Shtylyov <hidden>
Date: 2014-12-29 13:29:40
Hello. On 12/29/2014 1:09 PM, Enrico Mioso wrote:
The function might return NULL: callers must be prepared to this possibility.
Signed-Off-By: Enrico Mioso <redacted> --- drivers/net/usb/cdc_ncm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c index 48fee7a..bcd9437 100644 --- a/drivers/net/usb/cdc_ncm.c +++ b/drivers/net/usb/cdc_ncm.c@@ -1015,7 +1015,7 @@ static struct usb_cdc_ncm_ndp16 *cdc_ncm_ndp16(struct cdc_ncm_ctx *ctx, struct s } /* Allocate new SKB for use with 16-bit NCM according to actual TX/RX - settings */ + settings; returns NULL in case of errors */
BTW, the preferred style for the multi-line comments in the networking
code is:
/* bla
* bla
*/
WBR, Sergei