Thread (30 messages) 30 messages, 9 authors, 2014-12-11

Re: [net-next PATCH 6/6] ethernet/broadcom: Use napi_alloc_skb instead of netdev_alloc_skb_ip_align

From: Alexander Duyck <hidden>
Date: 2014-12-10 15:16:16

On 12/10/2014 01:52 AM, David Laight wrote:
From: David Laight
quoted
From: Alexander Duyck
quoted
This patch replaces the calls to netdev_alloc_skb_ip_align in the
copybreak paths.
Why?

You still want the IP header to be aligned and you also want the
memcpy() to be copying aligned data.

I suspect this fails on both counts?
Or am I confused by the naming?

	David
The bit you are missing is that napi_alloc_skb is always IP aligned. 
The general idea with napi_alloc_skb is that it is a cheaper way
allocate frames that are about to be passed up the stack as a NAPI or
GRO receive so the IP aligned part is a given.

- Alex
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help