RE: [net-next PATCH 6/6] ethernet/broadcom: Use napi_alloc_skb instead of netdev_alloc_skb_ip_align
From: David Laight <hidden>
Date: 2014-12-10 09:53:17
From: David Laight
From: Alexander Duyckquoted
This patch replaces the calls to netdev_alloc_skb_ip_align in the copybreak paths.Why? You still want the IP header to be aligned and you also want the memcpy() to be copying aligned data. I suspect this fails on both counts?
Or am I confused by the naming? David
Davidquoted
Cc: Gary Zambrano <redacted> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: Ariel Elior <redacted> Signed-off-by: Alexander Duyck <redacted> --- drivers/net/ethernet/broadcom/b44.c | 2 +- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 2 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c index ffeaf47..d86d6ba 100644 --- a/drivers/net/ethernet/broadcom/b44.c +++ b/drivers/net/ethernet/broadcom/b44.c@@ -836,7 +836,7 @@ static int b44_rx(struct b44 *bp, int budget) struct sk_buff *copy_skb; b44_recycle_rx(bp, cons, bp->rx_prod); - copy_skb = netdev_alloc_skb_ip_align(bp->dev, len); + copy_skb = napi_alloc_skb(&bp->napi, len); if (copy_skb == NULL) goto drop_it_no_recycle;
...