Thread (15 messages) flat view 15 messages, 3 authors, 2014-12-09

Re: [PATCH net-next 06/10] net/mlx4: Add mlx4_bitmap zone allocator

From: Or Gerlitz <hidden>
Date: 2014-12-09 20:29:39

On Tue, Dec 9, 2014 at 9:42 PM, David Miller [off-list ref] wrote:
From: Or Gerlitz <redacted>
Date: Thu,  4 Dec 2014 15:13:51 +0200
quoted
+static u32 mlx4_bitmap_max(struct mlx4_bitmap *bitmap)
+{
+     return bitmap->max;
+}
+
+static u32 mlx4_bitmap_effective_len(struct mlx4_bitmap *bitmap)
+{
+     return bitmap->effective_len;
+}
Using functions for just accessing structure members is excessive, please
just open code this.
sure, we will fix that, I see now that we have two fixes to apply, so
will respin the series and send it to you tomorrow.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help