Re: [PATCH net-next 02/10] net/mlx4_core: Mask out host side virtualization features for guests

On Tue, Dec 9, 2014 at 9:40 PM, David Miller [off-list ref] wrote:

From: Or Gerlitz <redacted>
Date: Thu,  4 Dec 2014 15:13:47 +0200

quoted

@@ -1053,6 +1053,11 @@ int mlx4_QUERY_DEV_CAP_wrapper(struct mlx4_dev *dev, int slave,
      field &= ~0x80;
      MLX4_PUT(outbox->buf, field, QUERY_DEV_CAP_FLOW_STEERING_IPOIB_OFFSET);

+     /* turn off host side virt features (VST, FSM, etc) for guests */
+     MLX4_GET(field32, outbox->buf, QUERY_DEV_CAP_EXT_2_FLAGS_OFFSET);
+     field32 &= ~((1 << 26) | (1 << 21) | (1 << 20));
+     MLX4_PUT(outbox->buf, field32, QUERY_DEV_CAP_EXT_2_FLAGS_OFFSET);
+

Please use mnenomics instead of magic constants for this, thanks.

OK, will do, if possible, I will be happy to send this as small fix in
a later (tomorrow!!) patch, thanks, Or.