Thread (5 messages) flat view 5 messages, 4 authors, 2014-11-12

Re: [PATCH -next 2/2] seq_putc: Convert to return void and convert uses too.

From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: 2014-11-12 12:29:00
Also in: linux-fsdevel, lkml, netfilter-devel

On Tue, Nov 11, 2014 at 02:47:40PM +0100, Petr Mladek wrote:
On Mon 2014-11-10 10:58:57, Joe Perches wrote:
quoted
Using the return value of seq_putc is error-prone, so
make it return void instead.

Reverse the logic in seq_putc to make it like seq_puts.

Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Petr Mladek <redacted>

The changes are correct. The show() functions should return 0
even when there is an overflow. They are called by traverse()
from seq_read() that might increase the buffer size and try again.
Just in case you need this for the netfilter chunks:

Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help