Thread (5 messages) flat view 5 messages, 4 authors, 2014-11-12

Re: [PATCH -next 2/2] seq_putc: Convert to return void and convert uses too.

From: Petr Mladek <hidden>
Date: 2014-11-11 13:47:40
Also in: linux-fsdevel, lkml, netfilter-devel

On Mon 2014-11-10 10:58:57, Joe Perches wrote:
Using the return value of seq_putc is error-prone, so
make it return void instead.

Reverse the logic in seq_putc to make it like seq_puts.

Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Petr Mladek <redacted>

The changes are correct. The show() functions should return 0
even when there is an overflow. They are called by traverse()
from seq_read() that might increase the buffer size and try again.


Best Regards,
Petr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help