Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c
From: Michael Büsch <m@bues.ch>
Date: 2014-11-28 23:22:20
Also in:
linux-wireless, lkml
On Fri, 28 Nov 2014 23:40:46 +0100 Rafał Miłecki [off-list ref] wrote:
quoted
@@ -5094,8 +5094,9 @@ static int b43_op_beacon_set_tim(struct ieee80211_hw *hw, { struct b43_wl *wl = hw_to_b43_wl(hw); - /* FIXME: add locking */ + mutex_lock(&wl->mutex); b43_update_templates(wl); + mutex_unlock(&wl->mutex); return 0; }Does anyone remember why this simple solution wasn't implemented earlier? Michael?
I think the callback used to be (is?) in atomic context.
Nicholas: did you test it anyhow?
-- Michael
Attachments
- (unnamed) [application/pgp-signature] 819 bytes