Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c
From: Rafał Miłecki <zajec5@gmail.com>
Date: 2014-11-28 22:40:49
Also in:
linux-wireless, lkml
On 28 November 2014 at 23:16, Nicholas Krause [off-list ref] wrote:
Adds needed mutex lockng of wl->mutex in order to prevent issues with separate threads executing on the b43_update_templates function call in the function, b43_op_beacon_set_time at the same time.
For all kind of kernel documentation / descriptions we try to fit 72 chars limit and we really try to avoid exceeding 80 chars.
quoted hunk ↗ jump to hunk
@@ -5094,8 +5094,9 @@ static int b43_op_beacon_set_tim(struct ieee80211_hw *hw, { struct b43_wl *wl = hw_to_b43_wl(hw); - /* FIXME: add locking */ + mutex_lock(&wl->mutex); b43_update_templates(wl); + mutex_unlock(&wl->mutex); return 0; }
Does anyone remember why this simple solution wasn't implemented earlier? Michael? Nicholas: did you test it anyhow?