Re: [PATCH 2/4] arch: Add lightweight memory barriers fast_rmb() and fast_wmb()
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2014-11-18 00:43:14
Also in:
linux-arch, lkml
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2014-11-18 00:43:14
Also in:
linux-arch, lkml
On Mon, 2014-11-17 at 12:52 -0800, Linus Torvalds wrote:
Maybe "dma_*mb()" would be acceptable, and ends up having the same naming convention as "smb_*mb()", and explains what it's about.
Yes, that was what I was about to suggest as well.
And yes, in the same spirit, it would probably be good to try to eventually get rid of the plain "*mb()" functions, and perhaps call them "mmio_*mb()" to clarify that they are about ordering memory wrt mmio.
It will always be somewhat unclear to users who don't read the doc anyway :) IE. the dma_* ones do only DMA vs DMA (or vs other processors) but the mmio_* one do anything vs anything. Not a huge deal tho. I still like dma_* for Alexander's new stuff but I wouldn't bother with changing the existing ones. Ben.