Hi David,

Lothar Waßmann wrote:

David Miller wrote:

quoted

From: Lothar Waßmann <redacted>
Date: Thu, 30 Oct 2014 07:51:04 +0100

quoted

quoted

Also, I don't thnk your DIV_ROUND_UP() eliminate for the loop
in swap_buffer() is valid.  The whole point is that the current
code handles buffers which have a length which is not a multiple
of 4 properly, after your change it will no longer do so.

Do you really think so?

Yes, because you're rounding down so you'll miss the final
partial word (if any).

Nope. DIV_ROUND_UP() would give '1' as upper bound for lengths from 1 to
4, '2' for lengths from 5 to 8 and so on.

The loop with increment 4 and i < len does exactly the same.
Try it for yourself, if you don't believe it.

Do you still think, the loop without DIV_ROUND_UP() is incorrect,
or can this patch be applied?


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________