Thread (6 messages) flat view 6 messages, 2 authors, 2014-10-23

Re: [PATCH v2] drivers: net: xgene: Rewrite loop in xgene_enet_ecc_init()

From: David Miller <davem@davemloft.net>
Date: 2014-10-22 19:34:39
Also in: lkml

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 22 Oct 2014 09:39:41 +0200
drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c: In function ‘xgene_enet_ecc_init’:
drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c:126: warning: ‘data’ may be used uninitialized in this function

Depending on the arbitrary value on the stack, the loop may terminate
too early, and cause a bogus -ENODEV failure.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
v2: Rewrite the loop instead of pre-initializing data.
I hate to be a pest, but like the other patch of your's I think
a do { } while() works best here because the intent is clearly
to run the loop at least once, right?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help