Re: [PATCH 1/1] Checkpatch: coding style errors in Nvidia ethernet driver
From: Joe Perches <joe@perches.com>
Date: 2014-10-10 15:03:14
Also in:
lkml
On Fri, 2014-10-10 at 13:31 +0530, Akshay Sarode wrote:
ERROR: "foo* bar" should be "foo *bar" ERROR: do not initialise statics to 0 or NULL CHECK: spinlock_t definition without comment Signed-off-by: Akshay Sarode <redacted>
[]
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
[]
quoted hunk ↗ jump to hunk
@@ -911,12 +913,18 @@ enum {
[]
/*
* Debug output control for tx_timeout
*/
-static bool debug_tx_timeout = false;
+enum {
+ NV_DEBUG_TX_TIMEOUT_DISABLED,
+ NV_DEBUG_TX_TIMEOUT_ENABLED
+};
+
+static bool debug_tx_timeout = NV_DEBUG_TX_TIMEOUT_DISABLED;Adding this enum is not useful.