Thread (27 messages) 27 messages, 6 authors, 2014-10-25

Re: [PATCH net] tcp: md5: percpu tcp_md5sig_pool must not span pages

From: Eric Dumazet <hidden>
Date: 2014-10-23 19:34:11

On Thu, 2014-10-23 at 09:33 -0700, Eric Dumazet wrote:
From: Eric Dumazet <edumazet@google.com>

percpu tcp_md5sig_pool contains memory blobs that ultimately
go through sg_set_buf().

-> sg_set_page(sg, virt_to_page(buf), buflen, offset_in_page(buf));

This requires that whole area is in a physically contiguous portion
of memory.

Given that alloc_percpu() can use vmalloc() areas, we need to make sure
tcp_md5sig_pool is allocated from a single page.


Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: 765cf9976e93 ("tcp: md5: remove one indirection level in tcp_md5sig_pool")
Reported-by: Crestez Dan Leonard <redacted>
---
Self Nack, we definitely need to avoid vmalloc() in the first place.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help